23 Nov, 2011, Nich wrote in the 2nd comment:
I'm not completely sure, since I don't know the codebase and my C is rusty, but I don't think the bug is in that code in particular. The bug would be in the function used to send players info.
From your example, a simplified version of what happens when a trigger is called is this: (I think)
The brackets represent scope, and there may be steps inbetween
nod -> (trigger -> trigger fires -> trigger prints) -> nod prints
p_act_trigger probably sends data to the user directly (speculating here), so you need to restructure your code to get more control over when that happens.
From your example, a simplified version of what happens when a trigger is called is this: (I think)
The brackets represent scope, and there may be steps inbetween
nod -> (trigger -> trigger fires -> trigger prints) -> nod prints
p_act_trigger probably sends data to the user directly (speculating here), so you need to restructure your code to get more control over when that happens.
23 Nov, 2011, Runter wrote in the 3rd comment:
That's one possibility perhaps. Another is the code can be executing too soon.
In this example, the mprog fires before the text is ever sent. Note, this may be preferable. Once the text is sent out the door you can't halt it from mprog. At least, not easily. Anyways. Here's what you probably want:
execute mprog if text.triggered?(mprog)
ch.print(text)
In this example, the mprog fires before the text is ever sent. Note, this may be preferable. Once the text is sent out the door you can't halt it from mprog. At least, not easily. Anyways. Here's what you probably want:
ch.print text
execute mprog if text.triggers?(mprog)
23 Nov, 2011, Rarva.Riendf wrote in the 4th comment:
First thing I would check is where the act code is executed, because wat Nich is saying is probably right on tracks.
I know mine is in aggr_update, so this can not happen in my code.
I think I had these kind of problems in plenty places, ending up making mobs never ever call methods directly but use interp.c like any players as well.
Solved a lot of problems when your mobs actually act like players, as they should except for very few methods.
Using a debugger and following the code step by step should make it pretty obvious as well.
I know mine is in aggr_update, so this can not happen in my code.
I think I had these kind of problems in plenty places, ending up making mobs never ever call methods directly but use interp.c like any players as well.
Solved a lot of problems when your mobs actually act like players, as they should except for very few methods.
Using a debugger and following the code step by step should make it pretty obvious as well.
23 Nov, 2011, Hades_Kane wrote in the 5th comment:
Ok, looking at it further based on what's been said and the best I can tell, it's looking like the program_flow thing intercepts the command and does all of the program stuff first, and if allowed (in the case of something like the exall trigger, it isn't), allows the normal command to pass after the fact.
The program_flow code is such a gigantic mess, though, I think I'm better off just dealing with the slightly off order trigger stuff.
Thanks anyhow!
The program_flow code is such a gigantic mess, though, I think I'm better off just dealing with the slightly off order trigger stuff.
Thanks anyhow!
23 Nov, 2011, Rarva.Riendf wrote in the 6th comment:
How your mprog_act_trigger looks like ?
Mine is as simple as this: as you see if does not launch anyting yet, as the result would obvisouly be the same than yours
it just stores it there :mob->mpact = tmp_act;
To launch the mpact I have it done in aggr_update:
Mine is as simple as this: as you see if does not launch anyting yet, as the result would obvisouly be the same than yours
it just stores it there :mob->mpact = tmp_act;
void mprog_act_trigger(char *buf, CHAR_DATA *mob, CHAR_DATA *ch, OBJ_DATA *obj, void *vo) {
if ( !mob || IS_PC( mob ) || !(mob->pIndexData->progtypes & ACT_PROG))
return;
MPROG_ACT_LIST * tmp_act = malloc(sizeof(MPROG_ACT_LIST));
tmp_act->next = mob->mpact;
tmp_act->buf = str_dup(buf);
tmp_act->ch = ch;
tmp_act->obj = obj;
tmp_act->vo = vo;
mob->mpact = tmp_act;
}To launch the mpact I have it done in aggr_update:
for (ch = char_list;ch ;ch = ch->next) {
/* MOBProgram ACT_PROG trigger */
if ( IS_PC( ch ) || !ch->mpact || !ch->valid)
continue;
MPROG_ACT_LIST * tmp_act, *tmp_act_next;
for (tmp_act = ch->mpact;tmp_act && ch->valid;tmp_act = tmp_act_next) {
tmp_act_next = tmp_act->next;
mprog_wordlist_check(tmp_act->buf, ch, tmp_act->ch, tmp_act->obj, tmp_act->vo, ACT_PROG );
free_string( &tmp_act->buf);
free(tmp_act);
}
/* Zap the pointer to the memory */
ch->mpact = NULL;
} /* mprog loop */
Random Picks
Basically, when you trigger something with the act trigger on a mobprog, the program is executing before the messaging is sent.
For example, if I have 'act nod' as the program trigger with a mob echo of "Testing", it would look like:
Testing
You nod.
This is the same for oprogs and rprogs as well. Here is my act_new function, any suggestions would be greatly appreciated.