# comm.c: In function `void act_new(const char*, CHAR_DATA*, const void*, const void*, int, int)':
# comm.c:2443: warning: cast from `const void*' to `CHAR_DATA*' discards qualifiers from pointer target type
# comm.c:2444: warning: cast from `const void*' to `OBJ_DATA*' discards qualifiers from pointer target type
# comm.c:2445: warning: cast from `const void*' to `OBJ_DATA*' discards qualifiers from pointer target type
# comm.c:2512: warning: cast from `const void*' to `char*' discards qualifiers from pointer target type
# comm.c:2513: warning: cast from `const void*' to `char*' discards qualifiers from pointer target type
# comm.c:2536: warning: cast from `const void*' to `char*' discards qualifiers from pointer target type
# comm.c:2542: warning: cast from `const void*' to `char*' discards qualifiers from pointer target type
one_argument( (char *) arg2, fname )
one_argument( (char *) arg2, fname )
quixadhal@andropov:~/rom$ ls -al fixup_081004
total 0
?——— ? ? ? ? ? fixup_081004/.
?——— ? ? ? ? ? fixup_081004/..
?——— ? ? ? ? ? fixup_081004/HACKLOG
?——— ? ? ? ? ? fixup_081004/MudBytes
?——— ? ? ? ? ? fixup_081004/README
?——— ? ? ? ? ? fixup_081004/README.rom
?——— ? ? ? ? ? fixup_081004/README.version
?——— ? ? ? ? ? fixup_081004/area
?——— ? ? ? ? ? fixup_081004/doc
?——— ? ? ? ? ? fixup_081004/gods
?——— ? ? ? ? ? fixup_081004/log
?——— ? ? ? ? ? fixup_081004/player
?——— ? ? ? ? ? fixup_081004/src
quixadhal@andropov:~/rom$ sudo -s
root@andropov:~/rom# ls -al fixup_081004
total 60
drw-r–r– 8 quixadhal users 4096 Oct 3 23:18 .
drwxr-xr-x 8 quixadhal users 4096 Oct 5 19:55 ..
-rw-r—– 1 quixadhal users 8184 Oct 3 23:18 HACKLOG
-rw-r—– 1 quixadhal users 132 Mar 5 2007 MudBytes
-rw——- 1 quixadhal users 4873 Sep 7 1995 README
-rw——- 1 quixadhal users 1243 May 27 1998 README.rom
-rw——- 1 quixadhal users 24 May 29 1998 README.version
drwx—— 2 quixadhal users 4096 May 29 1998 area
drwx—— 2 quixadhal users 4096 May 27 1998 doc
drwx—— 2 quixadhal users 4096 Oct 23 1995 gods
drwx—— 2 quixadhal users 4096 Oct 9 1995 log
drwx—— 2 quixadhal users 4096 Mar 5 2007 player
drwx—— 2 quixadhal users 4096 Oct 3 23:22 src
daemon.log.0:Oct 5 01:06:01 andropov mdadm: RebuildStarted event detected on md device /dev/md1
daemon.log.0:Oct 5 01:06:15 andropov mdadm: RebuildStarted event detected on md device /dev/md6
daemon.log.0:Oct 5 01:06:15 andropov mdadm: RebuildFinished event detected on md device /dev/md1
daemon.log.0:Oct 5 01:07:15 andropov mdadm: Rebuild20 event detected on md device /dev/md6
daemon.log.0:Oct 5 01:08:15 andropov mdadm: Rebuild60 event detected on md device /dev/md6
daemon.log.0:Oct 5 01:09:09 andropov mdadm: RebuildStarted event detected on md device /dev/md9
daemon.log.0:Oct 5 01:09:09 andropov mdadm: RebuildFinished event detected on md device /dev/md6
daemon.log.0:Oct 5 01:14:09 andropov mdadm: Rebuild20 event detected on md device /dev/md9
daemon.log.0:Oct 5 01:19:09 andropov mdadm: Rebuild40 event detected on md device /dev/md9
daemon.log.0:Oct 5 01:24:09 andropov mdadm: Rebuild60 event detected on md device /dev/md9
daemon.log.0:Oct 5 01:29:09 andropov mdadm: Rebuild80 event detected on md device /dev/md9
daemon.log.0:Oct 5 01:34:28 andropov mdadm: RebuildFinished event detected on md device /dev/md9
daemon.log.0:Oct 5 01:34:28 andropov mdadm: RebuildStarted event detected on md device /dev/md8
daemon.log.0:Oct 5 01:34:47 andropov mdadm: RebuildFinished event detected on md device /dev/md8
daemon.log.0:Oct 5 01:34:47 andropov mdadm: RebuildStarted event detected on md device /dev/md5
daemon.log.0:Oct 5 01:35:47 andropov mdadm: Rebuild20 event detected on md device /dev/md5
daemon.log.0:Oct 5 01:36:47 andropov mdadm: Rebuild40 event detected on md device /dev/md5
daemon.log.0:Oct 5 01:37:47 andropov mdadm: Rebuild60 event detected on md device /dev/md5
daemon.log.0:Oct 5 01:38:44 andropov mdadm: RebuildStarted event detected on md device /dev/md7
daemon.log.0:Oct 5 01:38:44 andropov mdadm: RebuildFinished event detected on md device /dev/md5
daemon.log.0:Oct 5 01:39:44 andropov mdadm: Rebuild80 event detected on md device /dev/md7
daemon.log.0:Oct 5 01:39:57 andropov mdadm: RebuildFinished event detected on md device /dev/md7
/*
* Accomodate both gcc and g++
*/
#if !defined __cplusplus
typedef unsigned char bool;
#endif
That's part of the reason I wanted everyone to specify their development platform. g++ 4.1.2 compiled that without warnings. In fact, you might notice the -Werror flag I added which treats any warnings as full errors. That's been a debatable issue, but unless we can't get a superset of patches that don't produce warnings on *most* common compilers, I like it as the default.
As to making more things const…. yes, it would be a good thing to do. I actually removed const in a couple places just to clear up the warnings, because I know when this stuff was originally coded, nobody was really using good coding standards *grin*. Back in the early 1990's, it was perfectly acceptable for functions to have side effects, although they did suggest you document them in the headers. A few years of supporting that kind of code led us to realize that, no, side effects really are bad.
Ideally, if MacGregor could upload his patches (or provide a link) against what I did, we can see if the combined set still works clean against 4.1.2 as well.
I would say that we should NOT bother supporting anything OLDER than gcc 3.4.x. I think there's a limit on how much backwards compatibility is sane, and 3.4.4 was released in March of 2005 (3.4.0 was May 2004). That's not to say it wouldn't be nice if it'd compile on gcc 2.95 under SunOS 4.1 – but let's not bang our heads against that wall, we might get asbestos poisoning.
Oh yeah, come to think of it… did the older g++ accept all those extra warning flags I added? It occured to me that some of them might have been added more recently.